Hi Paul-Antoine, hi all, On 28.09.22 15:47, Paul-Antoine Arras wrote:
Here is a revised patch resulting from your comments. The only issue that I could not easily fix is the following code triggering an ICE: [...] I filed a PR on Bugzilla: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107067 Is it OK for you?
Thanks for the update – LGTM. (We may want to revise some general block handling, but that's something for either upstreaming – or even after the upstreaming hen fixing the PR.) Two minor remarks: (a) Don't forget to update the date in the ChangeLog.omp. (b) On can shorten bug URL by using https://gcc.gnu.org/PR107067 which is, well, shorter. (Similarly, https://gcc.gnu.org/g:<githash> or https://gcc.gnu.org/r... for the svn or 'git gcc-descr [--full]' revision number also works.) Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
