> On Oct 5, 2022, at 4:25 PM, Joseph Myers <jos...@codesourcery.com> wrote:
>
> On Wed, 5 Oct 2022, Qing Zhao via Gcc-patches wrote:
>
>> + /* if not the last field, return false. */
>
> Comments should start with an uppercase letter.
>
>> + /* if not an array field, return false. */
>
>> + /* if there is a strict_flex_array attribute attached to the field,
>> + override the flag_strict_flex_arrays. */
>
>> + /* get the value of the level first from the attribute. */
>
>> + /* the attribute has higher priority than flag_struct_flex_array. */
>
>> + /* default, all trailing arrays are flexiable array members. */
>
> Likewise, and "flexible" not "flexiable".
>
>> + /* whether this field is the last field of the structure or union.
>> + for UNION, any field is the last field of it. */
>
> Likewise.
>
>> +field of a structure as a flexible array member for the purposesof accessing
>
> Missing space, should be "purposes of".
Will fix all the above.
>
> The C front-end and docs changes are OK with the fixes above.
Thanks a lot.
So this patch is considered approved, I will commit it after the above fix and
one more round of testing.
Let me know if you have more comment.
Qing
>
> --
> Joseph S. Myers
> jos...@codesourcery.com
