On Fri, Oct 21, 2022 at 06:51:17PM +0200, Jakub Jelinek wrote: > On Fri, Oct 21, 2022 at 11:45:33AM -0500, Segher Boessenkool wrote: > > On Fri, Oct 21, 2022 at 03:14:26PM +0200, Aldy Hernandez via Gcc-patches > > wrote: > > > * asan.cc (handle_builtin_alloca): Rename *nonzero* to *known_zero*. > > > > Our "nonzero" means "not known to be zero", not "known to be zero", so > > this renaming makes it worse than it was. Rename it to > > Agreed. > > I think maybe_nonzero_bits would be fine.
Yes, but the shorter nam known_zero is much better. Converting to that is a bit more work, cannot really be mechanic: code simplifications are needed to make things better instead of adding another layer of double negations, and variable names and comments should be changes as well. > Anyway, the reason it is called this way is that we have similar APIs > on the RTL side, nonzero_bits* in rtlanal.cc. I am well aware ;-) > So if we rename, it should be renamed consistently. Yes. Segher
