Jiufu Guo via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
> Hi Kewen,
>
> 在 12/1/22 11:31 AM, Kewen.Lin 写道:
>> Hi Jeff,
>>
>> on 2022/12/1 09:36, Jiufu Guo wrote:
>>> Hi,
>>>
>>> Function rs6000_emit_set_const/rs6000_emit_set_long_const are only invoked
>>> from
>>> two "define_split"s where the target operand is limited to gpc_reg_operand
>>> or
>>> int_reg_operand, then the operand must be REG_P.
>>> And in rs6000_emit_set_const/rs6000_emit_set_long_const, to create temp rtx,
>>> it is using code like "gen_reg_rtx({S|D}Imode)", it must also be REG_P.
>>> So, copy_rtx is not needed for temp and dest.
>>>
>>> This patch removes those "copy_rtx" for rs6000_emit_set_const and
>>> rs6000_emit_set_long_const.
>>>
>>> Bootstrap & regtest pass on ppc64{,le}.
>>> Is this ok for trunk?
>>
>> This patch is okay, thanks! For the subject, IMHO it's better to use
>> something
>> like: "rs6000: Remove useless copy_rtx in rs6000_emit_set_{,long}_const".
>> I don't see NFC tag used much in GCC, though it's used a lot in llvm, but
>> anyway you can append (NFC)/[NFC] at the end if you like. :)
>>
>
> "rs6000: Remove useless copy_rtx in rs6000_emit_set_{,long}_const" is great!
>
> Thanks for your review and suggestions!
Thanks for comments and review! And committed via r13-4583-g71b31d13757ae0.
BR,
Jeff (Jiufu)
>
>
> BR,
> Jeff (Jiufu)
>
>> BR,
>> Kewen
