Jakub Jelinek <ja...@redhat.com> writes: > Hi! > > On top of the just posted patch, this patch makes sure that > any % chars in message strings aren't treated as format chars. > None of these functions take variable number of arguments, so for > most of format specifiers there is nowhere to take arguments from, > it is true that a couple of format specifiers don't take any > arguments - %%, %m, %<, %>, %' - so it is actually possible > to use them, but one needs to verify that no other are emitted and > that what should be printed as % is really emitted as %%. > If the FE does that, then please ignore this patch, otherwise I think > it is safer to do this. > > Bootstrapped/regtested on x86_64-linux and i686-linux.
yes it might be possible for % to slip though. Thus much safer to avoid the situation by using the patch. LGTM regards, Gaius
