On Thu, Jan 19, 2023 at 11:26 PM Bernhard Reutner-Fischer <rep.dot....@gmail.com> wrote: > > On 19 January 2023 20:39:08 CET, Jason Merrill <ja...@redhat.com> wrote: > >On Sat, Nov 12, 2022 at 4:24 PM Harald Anlauf via Gcc-patches > ><gcc-patches@gcc.gnu.org> wrote: > >> > >> Am 12.11.22 um 22:05 schrieb Bernhard Reutner-Fischer via Gcc-patches: > >> > This function definition was removed years ago, remove it's prototype. > >> > > >> > gcc/fortran/ChangeLog: > >> > > >> > * gfortran.h (gfc_check_include): Remove declaration. > >> > --- > >> > gcc/fortran/gfortran.h | 1 - > >> > 1 file changed, 1 deletion(-) > >> > --- > >> > Regtests cleanly, ok for trunk? > >> > > >> > diff --git a/gcc/fortran/gfortran.h b/gcc/fortran/gfortran.h > >> > index c4deec0d5b8..ce3ad61bb52 100644 > >> > --- a/gcc/fortran/gfortran.h > >> > +++ b/gcc/fortran/gfortran.h > >> > @@ -3208,7 +3208,6 @@ int gfc_at_eof (void); > >> > int gfc_at_bol (void); > >> > int gfc_at_eol (void); > >> > void gfc_advance_line (void); > >> > -int gfc_check_include (void); > >> > int gfc_define_undef_line (void); > >> > > >> > int gfc_wide_is_printable (gfc_char_t); > >> > >> OK, thanks. > > > >Somehow this was applied with a CommitDate in 2021, breaking scripts > >that assume monotonically increasing CommitDate. Anyone know how that > >could have happened? > > Sorry for that. > I think i cherry-picked this commit to master before pushing it, not 100% > sure though.
You would have also needed to override the commit date with GIT_COMMITTER_DATE. Do you remember using that environment variable at all? > What shall we do now? I don't think there's anything we can do about this commit at this point; rewriting the git history would be a bigger disruption than leaving it alone. Martin, I wonder about having the hooks reject out-of-order CommitDate in future? Jason
