On 3/7/23 01:32, Hans-Peter Nilsson wrote: >> From: Mike Stump <mikest...@comcast.net> >> Date: Mon, 6 Mar 2023 02:05:35 -0800 > >> Ok > > Thanks! The server-side hook didn't like my ChangeLog > entry: > > * lib/multiline.exp (_build_multiline_regex): Map > "{re:" to "(", ":re}" to ")" and ":re?}" to ")?". > > It seems I forgot to validate that patch by > contrib/gcc-changelog/git_check_commit.py, which complains: > > Checking c0debd6f586ef76f1ceabfed11d7eaf8f6d1b110: FAILED > ERR: bad wrapping of parenthesis: " "{re:" to "(", ":re}" to ")" and > ":re?}" to ")?"."
Hello. Yeah, that's quite interesting problem ;) > > I gave in and took the easy way out; not fixing the bug in > that script, but instead "wrapped the parenthesis" to: > > * lib/multiline.exp (_build_multiline_regex): Map > "{re:" to "(", similarly ")?" from ":re?}" and the > same without question mark. > > I hope to make amends by fixing git_check_commit.py, if > given guidance. Sure, you can take a look at: contrib/gcc-changelog/git_commit.py::process_parentheses where we might want to skip the stack push/pop if the character is wrapper in apostrophes or double quotes. Martin > > brgds, H-P