On Wed, Mar 08, 2023 at 04:54:20PM +0800, Hongyu Wang wrote: > > Seems for many ICVs the default values are done through > > gomp_default_icv_values, but that doesn't cover wait_policy. > > For other vars, the defaults are provided through just initializers of > > those vars on the var definitions, e.g.: > > char *gomp_affinity_format_var = "level %L thread %i affinity %A"; > > So, I'd do the initialize_icvs change and change > > static int wait_policy; > > to > > static int wait_policy = -1; > > Agreed, here is the updated patch, ok for trunk? > > When OMP_WAIT_POLICY is not specified, current implementation will cause > icv flag GOMP_ICV_WAIT_POLICY unset, so global variable wait_policy > will remain its uninitialized value. Initialize it to -1 to make > GOMP_SPINCOUNT behavior consistent with its description. > > libgomp/ChangeLog: > > PR libgomp/109062 > * env.c (wait_policy): Initialize to -1. > (initialize_icvs): Initialize icvs->wait_policy to -1. > * testsuite/libgomp.c-c++-common/pr109062.c: New test.
Ok, thanks. Jakub