Segher Boessenkool <seg...@kernel.crashing.org> writes: > Hi! > > On Thu, Mar 09, 2023 at 12:09:59PM +0000, Richard Sandiford wrote: >> This patch just splits some code out of make_compound_operation_int >> into a new function called make_compound_operation_and. It is a >> prerequisite for the fix for PR106594. >> >> It might (or might not) make sense to put more of the existing >> "and" handling into the new function, so that the subreg+lshiftrt >> case can be handled through recursion rather than duplication. >> But that's certainly not necessary to fix the bug, so is at >> best stage 1 material. >> >> No behavioural change intended. > > That doesn't sound as if you are very sure about things. I'll just > pretend it says "no functional changes" :-)
Heh. Stock phrase borrowed from LLVM. I'm not going to sign off with "this patch contains no bugs". :-) > (*Is* this a pure refactoring?) Yeah, this patch is a pure refactoring. It's the follow-on 2/2 part that does something useful. Thanks, Richard
