> On Thu, Mar 23, 2023 at 11:09:19AM +0100, Martin Jambor wrote:
> > Hi,
> >
> > PR 108959 shows one more example where undefined code with type
> > incompatible accesses to stuff passed in parameters can cause an ICE
> > because we try to create a VIEW_CONVERT_EXPR of mismatching sizes:
> >
> > 1. IPA-CP tries to push one type from above,
> >
> > 2. IPA-SRA (correctly) decides the parameter is useless because it is
> > only used to construct an argument to another function which does not
> > use it and so the formal parameter should be removed,
> >
> > 3. but the code reconciling IPA-CP and IPA-SRA transformations still
> > wants to perform the IPA-CP and overrides the built-in DCE of
> > useless statements and tries to stuff constants into them
> > instead, constants of a type with mismatching type and size.
> >
> > This patch avoids the situation in IPA-SRA by purging the IPA-CP
> > results from any "aggregate" constants that are passed in parameters
> > which are detected to be useless. It also removes IPA value range and
> > bits information associated with removed parameters stored in the same
> > structure so that the useless information is not streamed later on.
> >
> > Bootstrapped and LTO-bootstrapped and tested on x86_64-linux. OK for
> > trunk?
> >
> > gcc/ChangeLog:
> >
> > 2023-03-22 Martin Jambor <mjam...@suse.cz>
> >
> > PR ipa/108959
> > * ipa-sra.cc (zap_useless_ipcp_results): New function.
> > (process_isra_node_results): Call it.
> >
> > gcc/testsuite/ChangeLog:
> >
> > 2023-03-17 Martin Jambor <mjam...@suse.cz>
> >
> > PR ipa/108959
> > * gcc.dg/ipa/pr108959.c: New test.
OK,
thanks!
Honza
