Hello, Kewen,
On Apr 6, 2023, "Kewen.Lin" <li...@linux.ibm.com> wrote:
> on 2023/4/6 14:19, Alexandre Oliva wrote:
>> Skip ppc-fortran.exp if a trivial fortran program cannot be compiled.
> IIUC, without this patch and under the configuration disabling fortran,
> all the cases in this sub-testsuite would fail? Thanks for fixing!
Yup
> super nit: this check only needs proc check_no_compiler_messages,
> can it be moved a bit upward just after line "load_lib gfortran-dg.exp"
> then it can skip more unnecessary codes?
I wasn't sure, so I'd put it after supporting code. Turns out it can.
Here's what I've just finished retesting, and am thus checking in.
Thanks,
> OK with this nit fixed (if you agree). Thanks!
[testsuite] [ppc] skip ppc-fortran if fortran is disabled
Skip ppc-fortran.exp if a trivial fortran program cannot be compiled.
for gcc/testsuite/ChangeLog
* gcc.target/powerpc/ppc-fortran/ppc-fortran.exp: Test for
fortran compiler, skip if missing.
---
.../gcc.target/powerpc/ppc-fortran/ppc-fortran.exp | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.exp
b/gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.exp
index f7e99ac848753..f7b7c05487cda 100644
--- a/gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.exp
+++ b/gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.exp
@@ -21,6 +21,16 @@ if { ![istarget powerpc*-*-*] && ![istarget rs6000-*-*] }
then {
return
}
+# Make sure there is a fortran compiler to test.
+if { ![check_no_compiler_messages fortran_available assembly {
+! Fortran
+program P
+ stop
+end program P
+} ""] } {
+ return
+}
+
# Load support procs.
load_lib gfortran-dg.exp
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>
