Hi Haochen,
on 2023/4/12 10:27, HAO CHEN GUI wrote:
> Hi,
> This patch xfails a float128 comparison test case on powerpc64 that
> fails due to a longstanding issue with floating-point compares.
>
> See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58684 for more
> information.
>
> The patch passed regression test on Power Linux platforms.
>
> Thanks
> Gui Haochen
>
> ChangeLog
> rs6000: xfail float128 comparison test case that fails on powerpc64.
>
> This patch xfails a float128 comparison test case on powerpc64 that
> fails due to a longstanding issue with floating-point compares.
>
> See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58684 for more information.
>
> gcc/testsuite/
> PR target/108728
> * gcc.dg/torture/float128-cmp-invalid.c: Add xfail.
>
> patch.diff
> diff --git a/gcc/testsuite/gcc.dg/torture/float128-cmp-invalid.c
> b/gcc/testsuite/gcc.dg/torture/float128-cmp-invalid.c
> index 1f675efdd61..f52686e0a24 100644
> --- a/gcc/testsuite/gcc.dg/torture/float128-cmp-invalid.c
> +++ b/gcc/testsuite/gcc.dg/torture/float128-cmp-invalid.c
> @@ -1,5 +1,5 @@
> /* Test for "invalid" exceptions from __float128 comparisons. */
> -/* { dg-do run } */
> +/* { dg-do run { xfail { powerpc*-*-* } } } */
xfail all powerpc*-*-* can have some XPASSes on those ENVs with
software emulation. Since the related hw insn xscmpuqp is guarded
with TARGET_FLOAT128_HW, could we use the effective target
ppc_float128_hw instead?
Maybe something like:
/* { dg-xfail-run-if "unexpected xscmpuqp" { ppc_float128_hw } } */
BR,
Kewen
> /* { dg-options "" } */
> /* { dg-require-effective-target __float128 } */
> /* { dg-require-effective-target base_quadfloat_support } */
