> @@ -1151,14 +1169,26 @@ riscv_subset_list::parse (const char *arch, > location_t loc) > subset_list->handle_implied_ext (itr); > } > > + /* Zce only imply zcf when 'f' extension exist. */
Grammarly and gmail told me it should be "Zce only implies zcf when 'f' extension exist." :P > + if (subset_list->lookup ("zce") != NULL > + && subset_list->lookup ("f") != NULL > + && subset_list->lookup ("zcf") == NULL) Wait, add zce if f not implied here, but how about rv64if_zce? it will become rv64if_zce_zcf and then error later. > + subset_list->add ("zcf", false); > + > subset_list->handle_combine_ext (); > > + if (subset_list->lookup ("zcf") && subset_list->m_xlen == 64) > + error_at (loc, "%<-march=%s%>: zcf extension supports in rv32 only" > + , arch); > + > if (subset_list->lookup ("zfinx") && subset_list->lookup ("f")) > error_at (loc, "%<-march=%s%>: z*inx conflicts with floating-point " > "extensions", arch); > > return subset_list; > > + > + Plz drop these two extra blank lines.