LGTM, and just one nit, use RISC-V in the title would be better since Palmer's patchwork filter is set to "RISC-V", so using "riscv:" might be missed during patchwork review meeting :P
On Thu, May 11, 2023 at 2:54 AM Palmer Dabbelt <pal...@dabbelt.com> wrote: > > On Wed, 10 May 2023 11:50:32 PDT (-0700), rdapp....@gmail.com wrote: > >> It's somewhat common for mail clients to treat "--" as a signature > >> deliminator, it's "---" that git uses as a comment deliminator. > > > > It's in my muscle memory somehow. Always did it that way because I > > didn't want the same delimiter as in the git part of the message. Time > > to change that habit I suppose :) (or automate more of the process). > > I guess if you're committing your own code it doesn't matter, but mixing > them will trip up git-am and such. > > The patch LGTM, but it's mostly Juzhe's code so it's probably best to at > least give him a chance to see it when he's awake.
