> emit_merge_op can not be wrapped into binop since mask position is
> different in pattern.
> 
> I prefer merge op in different wrapper.

Yes, I didn't mean literally the same but that things already
become a bit confusing with all the different variants and bool
arguments or code duplication with slight differences.  Something
like foo (true, false, true) is a bit of a code smell.  Nothing
to address immediately, I just need to keep an eye on it.  Shouldn't
prevent the patch from going in.

Reply via email to