On Fri, 12 May 2023 at 19:05, Uros Bizjak <ubiz...@gmail.com> wrote: > > On Fri, May 12, 2023 at 4:07 PM Ard Biesheuvel <a...@kernel.org> wrote: > > > > > > > Note that the GOT reference in question is in fact a data > > > > > > reference: we > > > > > > explicitly load the address of __fentry__ from the GOT, which > > > > > > amounts to > > > > > > eager binding, rather than emitting a PLT call that could bind > > > > > > eagerly, > > > > > > lazily or directly at link time. > > > > > > > > > > > > gcc/ChangeLog: > > > > > > > > > > > > * config/i386/i386.cc (x86_function_profiler): Take > > > > > > ix86_direct_extern_access into account when generating > > > > > > calls > > > > > > to __fentry__() > > > > > > > > > > HJ, is the patch OK with you? > > > > > > > > LGTM. > > > > > > OK then. > > > > > > > Thanks all. Is anything expected of me at this point? > > Do you have write access to the repository? If not I can commit the > patch for you
Yes, please. , but you should state this [1] in your patch submission. > > [1] https://gcc.gnu.org/contribute.html > Signed-off-by: Ard Biesheuvel <a...@kernel.org> Thanks,