Yeah, I agree wit kito. For example, I see you have rename "get_prefer_***" into "get_preferred_**" I think this NFC patch should be separated patch.
Thanks. juzhe.zh...@rivai.ai From: Kito Cheng Date: 2023-05-22 17:05 To: Robin Dapp CC: 钟居哲; gcc-patches; palmer; Michael Collison; Jeff Law Subject: Re: [PATCH] RISC-V: Implement autovec abs, vneg, vnot. So I expect you will also apply those refactor on Juzhe's new changes? If so I would like to have a separated NFC refactor patch if possible. e.g. Juzhe's vec_cmp/vcond -> NFC refactor patch -> abs, vneg, vnot On Mon, May 22, 2023 at 4:59 PM Robin Dapp <rdapp....@gmail.com> wrote: > > As discussed with Juzhe off-list, I will rebase this patch against > Juzhe's vec_cmp/vcond patch once that hits the trunk. > > Regards > Robin
