On Tue, May 30, 2023 at 9:01 PM Jeff Law via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
>
>
> On 5/30/23 08:36, Uros Bizjak via Gcc-patches wrote:
> > gcc/ChangeLog:
> >
> > * rtl.h (comparison_dominates_p): Change return type from int to bool.
> > (condjump_p): Ditto.
> > (any_condjump_p): Ditto.
> > (any_uncondjump_p): Ditto.
> > (simplejump_p): Ditto.
> > (returnjump_p): Ditto.
> > (eh_returnjump_p): Ditto.
> > (onlyjump_p): Ditto.
> > (invert_jump_1): Ditto.
> > (invert_jump): Ditto.
> > (rtx_renumbered_equal_p): Ditto.
> > (redirect_jump_1): Ditto.
> > (redirect_jump): Ditto.
> > (condjump_in_parallel_p): Ditto.
> > * jump.cc (invert_exp_1): Adjust forward declaration.
> > (comparison_dominates_p): Change return type from int to bool
> > and adjust function body accordingly.
> > (simplejump_p): Ditto.
> > (condjump_p): Ditto.
> > (condjump_in_parallel_p): Ditto.
> > (any_uncondjump_p): Ditto.
> > (any_condjump_p): Ditto.
> > (returnjump_p): Ditto.
> > (eh_returnjump_p): Ditto.
> > (onlyjump_p): Ditto.
> > (redirect_jump_1): Ditto.
> > (redirect_jump): Ditto.
> > (invert_exp_1): Ditto.
> > (invert_jump_1): Ditto.
> > (invert_jump): Ditto.
> > (rtx_renumbered_equal_p): Ditto.
> >
> > Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.
> >
> > OK for master?
> OK.
Do we have a diagnostic that would point out places we
assign the bool result to an integer variable? Do we want
to change those places as well (did you intend to or restrict
the changes to functions only used in conditional context?)
Richard.
> jeff
