I have sent V2 withing adding commen: https://gcc.gnu.org/pipermail/gcc-patches/2023-May/620243.html Could you take a look at it?
juzhe.zh...@rivai.ai From: Jeff Law Date: 2023-05-31 20:58 To: Robin Dapp; juzhe.zhong; gcc-patches CC: kito.cheng; kito.cheng; palmer; palmer Subject: Re: [PATCH] RISC-V: Add vwadd<u>/vwsub<u>/vwmul<u>/vwmulsu.vv lowering optimizaiton for RVV auto-vectorization On 5/31/23 05:55, Robin Dapp wrote: > Hi Juzhe, > >> The approach is quite simple and obvious, changing extension pattern >> into define_insn_and_split will make combine PASS combine into widen >> operations naturally. > > looks good to me. Tiny nit: I would add a comment above the patterns > to clarify why insn_and_split instead of expand. Something like "to help > combine match...", no need for a V2 though. OK with that change. jeff
