On Thu, 1 Jun 2023 10:53:02 +0530 Ajit Agarwal via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
> Hello All: > > This new version of patch 4 use improve ree pass for rs6000 target using > defined ABI interfaces. > Bootstrapped and regtested on power64-linux-gnu. > > Review comments incorporated. Not a review: /scratch/src/gcc-14.mine$ ./contrib/check_GNU_style.py /tmp/rs6k-ree-v5.patch === ERROR type #1: there should be exactly one space between function name and parenthesis (2 error(s)) === gcc/ree.cc:1461:33: if (state.defs_list.length() != 0) gcc/ree.cc:1487:42: if ((i+1) < reinsn_copy_list.length()) === ERROR type #2: trailing operator (1 error(s)) === gcc/ree.cc:761:24: machine_mode tgt_mode = $ grep -E "^[-+].*[^[:space:]\.][[:space:]][[:space:]]" /tmp/rs6k-ree-v5.patch + an return registers. */ + if (GET_CODE (SET_SRC (set)) != ZERO_EXTEND) + if (GET_CODE (SET_SRC (set)) != ZERO_EXTEND) + if (code != ZERO_EXTEND) And maybe you could add fewer empty lines in combine_reaching_defs() thanks,
