Hi Pan,
I only just now got back to my mails and I'm a bit confused about
the several patches related to rounding mode.
> 1. By default, the RVV floating-point will take dyn mode.
Here you are referring to 10.1 in the spec I assume. Could we
add this as a comment in the code?
> 2. DYN is invalid in FRM register for RVV floating-point.
What does that mean or rather how is that reflected in the code?
> - return code >= 0 ? get_attr_frm_mode (insn) : FRM_MODE_NONE;
> + return code >= 0 ? get_attr_frm_mode (insn) : FRM_MODE_DYN;
This still has yesterday's bug right? I.e. get_attr_frm_mode returns
5 for dyn instead of 7 because the enums don't match (leading to
SIGILL).
> +++ b/gcc/testsuite/gcc.target/riscv/rvv/base/float-point-frm-insert-6.c
> @@ -0,0 +1,31 @@
> +/* { dg-do compile } */
> +/* { dg-options "-march=rv64gcv -mabi=lp64 -O3 -Wno-psabi" } */
I would prefer to have an execution test here as well. Even
though we likely FAIL in other tests when the rounding mode
is off, it would be good to have a specific one. Maybe it
doesn't exactly fit into this patch but in general.
Regards
Robin
