On Thu, 6 Jul 2023, Tamar Christina wrote: > > On Wed, 28 Jun 2023, Tamar Christina wrote: > > > > > Hi All, > > > > > > expand_vector_piecewise does not support VLA expansion as it has a > > > hard assert on the type not being VLA. > > > > > > Instead of just failing to expand and so the call marked unsupported we > > > ICE. > > > This adjust it so we don't and can gracefully handle the expansion in > > > support checks. > > > > > > Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. > > > > > > Ok for master? > > > > Hmm, do we support _any_ VLA "generic" vectors? That is, why do we get > > here at all? Doesn't that mean the vectorizer creates code that vector > > lowering > > thinks is not supported by the target? > > > > In any case I'd expect expand_vector_operations_1 at > > > > if (compute_type == NULL_TREE) > > compute_type = get_compute_type (code, op, type); > > if (compute_type == type) > > return; > > > > <---- here > > > > new_rhs = expand_vector_operation (gsi, type, compute_type, stmt, code, > > dce_ssa_names); > > > > to be able to assert that compute_type (or even type) isn't VLA? > > > > So, why do we arrive here? > > > > I think we used to arrive here because the patch last year didn't properly > check the cmp, > I don't his it with this new patch so I'll drop it. I thought it was an > actual bug hence why I > submitted the patch ?
If it's a genuine bug then the fix at least looks wrong ;) Anyway, dropping is fine with me of course. Richard.
