MASK4 0, 5, 6, 7 also works definitely.

The optimization is generic as long as the permutation index matches the 
compress insn on RVV ISA SPEC.



juzhe.zh...@rivai.ai
 
From: Robin Dapp
Date: 2023-07-11 20:24
To: 钟居哲; gcc-patches
CC: rdapp.gcc; kito.cheng; kito.cheng; Jeff Law
Subject: Re: [PATCH] RISC-V: Optimize permutation codegen with vcompress
> The compress optimization pattern has included all variety.
> It's not necessary to force split (half/half), we can apply this compress
> pattern to any variety of compress pattern.
 
Yes, that's clear.  I meant the testcases are mostly designed
like
 
MASK4 1, 2, 6, 7
 
instead of variation like
 
MASK4 0, 5, 6, 7
 
or something else.  But this wouldn't add a lot of coverage
anyway as we're searching for the "pivot" anyway.
 
Regards
Robin
 

Reply via email to