On 7/17/23 05:55, Andre Vieira (lists) wrote:


On 11/07/2023 23:28, Jeff Law wrote:


On 7/11/23 04:37, Andre Vieira (lists) via Gcc-patches wrote:
Hi,

This patch fixes PR110610 by including OPTABS_H in the INTERNAL_FN_H list, as insn-opinit.h is now required by internal-fn.h. This will lead to insn-opinit.h, among the other OPTABS_H header files, being installed in the plugin directory.

Bootstrapped aarch64-unknown-linux-gnu.

@Jakub: could you check to see if it also addresses PR 110284?


gcc/ChangeLog:

         PR 110610
         * Makefile.in (INTERNAL_FN_H): Add OPTABS_H.
Why use OPTABS_H here?  Isn't the new dependency just on insn-opinit.h and insn-codes.h and neither of those #include other headers do they?



Yeah, there was no particular reason other than I just felt the Makefile structure sort of lend itself that way. I checked genopinit.cc and it seems insn-opinit.h doesn't include any other header files, only the sources do, so I've changed the patch to only add insn-opinit.h to INTERNAL_FN_H.

-------------------

This patch fixes PR110610 by including insn-opinit.h in the INTERNAL_FN_H list, as insn-opinit.h is now required by internal-fn.h. This will lead to insn-opinit.h, among the other OPTABS_H header files, being installed in the plugin directory.

Bootstrapped aarch64-unknown-linux-gnu.

gcc/ChangeLog:
         PR 110610
         * Makefile.in (INTERNAL_FN_H): Add insn-opinit.h.
OK
jeff

Reply via email to