Committed V2 patch, thank you so much.
------------------ Original ------------------ From: "Robin Dapp" <gcc-patches@gcc.gnu.org>; Date: Wed, Jul 19, 2023 02:03 PM To: "Lehua Ding"<lehua.d...@rivai.ai>;"gcc-patches"<gcc-patches@gcc.gnu.org>; Cc: "rdapp.gcc"<rdapp....@gmail.com>;"juzhe.zhong"<juzhe.zh...@rivai.ai>;"kito.cheng"<kito.ch...@gmail.com>;"palmer"<pal...@rivosinc.com>;"jeffreyalaw"<jeffreya...@gmail.com>; Subject: Re: [PATCH] RISC-V: Fix testcase failed when default -mcmodel=medany Hi Lehua, > I think you are rigth, I would like to remove the `-mcmodel=medany` option and > relax assert from `__riscv_save/restore_4` to `__riscv_save/restore_(3|4)` to let > this testcase not brittle on any -mcmodel. Then I'm also going to add another > testcase (I dont known how to run -march=rv32imafc and -march=rv64imafc on > the same testcase) that uses -march=rv64imafc. Thanks, ideally we'd have a common include that contains the code but I don't think we need to stress on that now. At a later point, we'd ideally have no rv32/rv64 ever in the options (apart from specific bugs) and just run the test suite for both so only one file would be needed. But we don't have that yet, so LGTM. Regards Robin