On Wed, Jul 19, 2023 at 01:58:21PM +0800, Hongtao Liu wrote:
> > LGTM, if you need someone to rubber-stamp the patch. I'm not really
> > versed in this part of the compiler, so please wait a day if someone
> > has anything to say about the patch.
> Thanks, pushed to trunk.
I see some regressions most likely with this change on i686-linux,
in particular:
+FAIL: gcc.dg/pr107547.c (test for excess errors)
+FAIL: gcc.dg/torture/floatn-convert.c -O0 (test for excess errors)
+UNRESOLVED: gcc.dg/torture/floatn-convert.c -O0 compilation failed to
produce executable
+FAIL: gcc.dg/torture/floatn-convert.c -O1 (test for excess errors)
+UNRESOLVED: gcc.dg/torture/floatn-convert.c -O1 compilation failed to
produce executable
+FAIL: gcc.dg/torture/floatn-convert.c -O2 (test for excess errors)
+UNRESOLVED: gcc.dg/torture/floatn-convert.c -O2 compilation failed to
produce executable
+FAIL: gcc.dg/torture/floatn-convert.c -O2 -flto (test for excess errors)
+UNRESOLVED: gcc.dg/torture/floatn-convert.c -O2 -flto compilation failed to
produce executable
+FAIL: gcc.dg/torture/floatn-convert.c -O2 -flto -flto-partition=none (test
for excess errors)
+UNRESOLVED: gcc.dg/torture/floatn-convert.c -O2 -flto -flto-partition=none
compilation failed to produce executable
+FAIL: gcc.dg/torture/floatn-convert.c -O3 -fomit-frame-pointer
-funroll-loops -fpeel-loops -ftracer -finline-functions (test for excess
errors)
+UNRESOLVED: gcc.dg/torture/floatn-convert.c -O3 -fomit-frame-pointer
-funroll-loops -fpeel-loops -ftracer -finline-functions compilation failed to
produce executable
+FAIL: gcc.dg/torture/floatn-convert.c -O3 -g (test for excess errors)
+UNRESOLVED: gcc.dg/torture/floatn-convert.c -O3 -g compilation failed to
produce executable
+FAIL: gcc.dg/torture/floatn-convert.c -Os (test for excess errors)
+UNRESOLVED: gcc.dg/torture/floatn-convert.c -Os compilation failed to
produce executable
+FAIL: gcc.target/i386/float16-7.c (test for errors, line 7)
Perhaps we need to tweak
gcc/testsuite/lib/target-supports.exp (add_options_for_float16)
so that it adds -msse2 for i?86-*-* x86_64-*-* (that would likely
fix up floatn-convert) and for the others perhaps
/* { dg-add-options float16 } */
?
Jakub
