On Thu, 17 Aug 2023, Prathamesh Kulkarni wrote: > On Tue, 15 Aug 2023 at 14:28, Richard Sandiford > <richard.sandif...@arm.com> wrote: > > > > Richard Biener <rguent...@suse.de> writes: > > > On Mon, 14 Aug 2023, Prathamesh Kulkarni wrote: > > >> On Mon, 7 Aug 2023 at 13:19, Richard Biener <richard.guent...@gmail.com> > > >> wrote: > > >> > It doesn't seem to make a difference for x86. That said, the "fix" is > > >> > probably sticking the correct target on the dump-check, it seems > > >> > that vect_fold_extract_last is no longer correct here. > > >> Um sorry, I did go thru various checks in target-supports.exp, but not > > >> sure which one will be appropriate for this case, > > >> and am stuck here :/ Could you please suggest how to proceed ? > > > > > > Maybe Richard S. knows the magic thing to test, he originally > > > implemented the direct conversion support. I suggest to implement > > > such dg-checks if they are not present (I can't find them), > > > possibly quite specific to the modes involved (like we have > > > other checks with _qi_to_hi suffixes, for float modes maybe > > > just _float). > > > > Yeah, can't remember specific selectors for that feature. TBH I think > > most (all?) of the tests were AArch64-specific. > Hi, > As Richi mentioned above, the test now vectorizes on AArch64 because > it has support for direct conversion > between vectors while x86 doesn't. IIUC this is because > supportable_convert_operation returns true > for V4HI -> V4SI on Aarch64 since it can use extend_v4hiv4si2 for > doing the conversion ? > > In the attached patch, I added a new target check vect_extend which > (currently) returns 1 only for aarch64*-*-*, > which makes the test PASS on both the targets, altho I am not sure if > this is entirely correct. > Does the patch look OK ?
Can you make vect_extend more specific, say vect_extend_hi_si or what is specifically needed here? Note I'll have to investigate why x86 cannot vectorize here since in fact it does have the extend operation ... it might be also worth splitting the sign/zero extend case, so - vect_sign_extend_hi_si or vect_extend_short_int? > Thanks, > Prathamesh > > > > Thanks, > > Richard > -- Richard Biener <rguent...@suse.de> SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)
