Kewen: On Tue, 2023-08-29 at 16:54 +0800, Kewen.Lin wrote: > > The following functions require @option{-mhard-float}, > > diff --git a/gcc/testsuite/gcc.target/powerpc/pr93448.c > > b/gcc/testsuite/gcc.target/powerpc/pr93448.c > > new file mode 100644 > > index 00000000000..f9c388585d7 > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/powerpc/pr93448.c > > @@ -0,0 +1,200 @@ > > +/* { dg-do run } */ > > +/* { dg-require-effective-target dfp_hw} */ > > +/* { dg-require-effective-target has_arch_pwr6} */ > > Sorry, I didn't catch this in the previous reviews. > "dfp_hw" and "has_arch_pwr6" don't have the expected > space after, without the space, the checkings would > be useless and this case can fail. So they should be: > > /* { dg-require-effective-target dfp_hw } */ > /* { dg-require-effective-target has_arch_pwr6 } */ > > Okay for trunk with this fixed, thanks!
OK, I take it the parsing of the lines by the test scripts will fail without the space since it can't parse it correctly. Thanks for letting me know. Here is the fixed up code. Note, I added the space before the "}" and removed the extra space before dfp_hw and has_arch_pwr6. get/powerpc/pr93448.c new file mode 100644 index 00000000000..6b800f8d63d --- /dev/null +++ b/gcc/testsuite/gcc.target/powerpc/pr93448.c @@ -0,0 +1,200 @@ +/* { dg-do run } */ +/* { dg-require-effective-target dfp_hw } */ +/* { dg-require-effective-target has_arch_pwr6 } */ +/* { dg-options "-mhard-float -O2 -save-temps" } */ + +/* Test the decimal floating point quantize built-ins. */ I will go ahead and commit the patch. Thanks for all your help. Carl