On Wed, Sep 6, 2023 at 5:44 PM FX Coudert <fxcoud...@gmail.com> wrote: > > Hi, > > ping**2 on the revised patch, for Richard or another global reviewer. So far > all review feedback is that it’s a step forward, and it’s been widely used > for both aarch64-darwin and x86_64-darwin distributions for almost three > years now. > > OK to commit?
I just noticed that ftrampoline-impl isn't Optimize, thus it's not streamed with LTO. How does mixing different -ftrampoline-impl for different LTO TUs behave? How does mis-specifying -ftrampoline-impl at LTO link time compared to compile-time behave? Is the state fully reflected during pre-IPA compilation and the flag not needed after that? It appears so, but did you check? OK if that's a non-issue. Thanks, Richard. > FX > > > > > Le 5 août 2023 à 16:20, FX Coudert <fxcoud...@gmail.com> a écrit : > > > > Hi Richard, > > > > Thanks for your feedback. Here is an amended version of the patch, taking > > into consideration your requests and the following discussion. There is no > > configure option for the libgcc part, and the documentation is amended. The > > patch is split into three commits for core, target and libgcc. > > > > Currently regtesting on x86_64 linux and darwin (it was fine before I split > > up into three commits, so I’m re-testing to make sure I didn’t screw > > anything up). > > > > OK to commit? > > FX >
