On 9/5/23 23:19, Jason Merrill wrote:
Tested x86_64-pc-linux-gnu, applying to trunk.
-- 8< --
We were checking for overlap using same_type_p and therefore allocating two
Empty subobjects at the same offset because one was cv-qualified.
This gives the warning at the location of the class name rather than the
member declaration, but this should be a rare enough issue that it doesn't
seem worth trying to be more precise.
The ABI and language seem to be settling on referring to "similar types"
here rather than same ignoring top-level cv-qualifiers.
Tested x86_64-pc-linux-gnu, applying to trunk.
From 3f65c1dc56f3a6dd4be85a064d0023b7be3fcd8a Mon Sep 17 00:00:00 2001
From: Jason Merrill <ja...@redhat.com>
Date: Tue, 12 Sep 2023 12:15:13 -0400
Subject: [PATCH] c++: overlapping subobjects tweak
To: gcc-patches@gcc.gnu.org
The ABI is settling on "similar" for this rule.
gcc/cp/ChangeLog:
* class.cc (check_subobject_offset): Use similar_type_p.
---
gcc/cp/class.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/cp/class.cc b/gcc/cp/class.cc
index 9139a0075ab..d270dcbb14c 100644
--- a/gcc/cp/class.cc
+++ b/gcc/cp/class.cc
@@ -4065,7 +4065,7 @@ check_subobject_offset (tree type, tree offset, splay_tree offsets)
return 1;
if (cv_check != ignore
- && same_type_ignoring_top_level_qualifiers_p (elt, type))
+ && similar_type_p (elt, type))
{
if (cv_check == fast)
return 1;
--
2.39.3
