On Mon, 25 Sep 2023, Maciej W. Rozycki wrote: > NB the use of this specific <assert.h> header, still in place elsewhere, > seems gratuitous to me. We don't need or indeed want to print anything in > the test cases (unless verifying something specific to the print facility) > and if we want to avoid minor code duplication (i.e. not to have explicit: > > if (...) > __builtin_abort (); > > replicated across test cases), we can easily implement this via a local > header, there's no need to pull in a complex system facility.
Overall we ought not to require any system headers in compile tests and then link and run tests need a functional target environment anyway. So maybe the use of <assert.h> in run tests isn't as bad after all if not for the -DNDEBUG peculiarity. However I still think the less we depend in verification on external components the better, that's one variable to exclude. Maciej
