On 10/2/23 11:20, David Edelsohn wrote:
Wang,

The AWK portions of this patch broke bootstrap on AIX.

Also, the AWK portions are common code, not RISC-V specific.  I don't see anywhere that the common portions of the patch were reviewed or approved by anyone with authority to approve the changes to the AWK files.

This patch should not have been committed without approval by a reviewer with authority for that portion of the compiler and should have been tested on targets other than RISC-V if common parts of the compiler were changed.
I acked the generic bits. So the lack of testing on another target is on me.

jeff

Reply via email to