Ping! please review.
Thanks & Regards Jeevitha On 16/06/23 9:55 am, Peter Bergner wrote: > On 6/12/23 6:18 AM, P Jeevitha wrote: >> Bitwise xor performed on bool >> is similar to checking inequality. So changed to inequality >> operator (!=) instead of bitwise xor (^). > [snip' >> - if (swapped ^ !BYTES_BIG_ENDIAN > [snip] >> + if (swapped != !BYTES_BIG_ENDIAN > > I know Andreas mentioned using "swapped != !BYTES_BIG_ENDIAN" in > the bugzilla, but that's the same as "swapped == BYTES_BIG_ENDIAN", > and it doesn't contain a double-negative and seems a little clearer. > > It's up to Segher though...and if we go with this, then the ChangeLog > entry needs to be updated slightly since we're no longer testing for > inequality. > > Peter >
