On 16 May 2012 19:47, Chung-Lin Tang <clt...@codesourcery.com> wrote: > On 2012/5/10 04:53 AM, Manuel López-Ibáñez wrote: >> 2012-05-09 Manuel López-Ibáñez <m...@gcc.gnu.org> >> >> PR 53063 >> gcc/ >> * doc/options.texi (EnabledBy): Document >> * opts.c: Include opts.h and options.h before tm.h. >> (finish_options): Do not handle some sub-options here... >> (common_handle_option): ... instead call common_handle_option_auto >> here. >> * optc-gen.awk: Handle EnabledBy. >> * opth-gen.awk: Declare common_handle_option_auto. >> * common.opt (Wuninitialized): Use EnabledBy. Delete Init. >> (Wmaybe-uninitialized): Likewise. >> (Wunused-but-set-variable): Likewise. >> (Wunused-function): Likewise. >> (Wunused-label): Likewise. >> (Wunused-value): Likewise. >> (Wunused-variable): Likewise. >> * opt-read.awk: Create opt_numbers array. >> ada/ >> * gcc-interface/misc.c (gnat_parse_file): Move before ... >> (gnat_handle_option): ... this. Use handle_generated_option. >> c-family/ >> * c-opts.c (c_common_handle_option): Use handle_generated_option >> to enable sub-options. >> fortran/ >> * options.c: Include diagnostics.h instead of >> diagnostics-core.h. >> (set_Wall): Do not see warn_unused here. >> (gfc_handle_option): Set it here using handle_generated_option. > > I'm guessing these changes are the cause of a full C bootstrap > (--disable-build-poststage1-with-cxx) failure I'm seeing on trunk. The > *_handle_option_auto function prototypes are not seen in options.c, and > -Werror -Wmissing-prototypes are in effect (oddly, such strict checking > is not enforced in the default post-stage1 C++ bootstrap)
Yep, We should add -Wmissing-declarations to the post-stage1 flags, which also exists in C. Could you also add that to your patch? > Here's a simple one-liner Makefile.in change that seems to make things > work. Okay to commit? I cannot approve, but I guess it is either this or also declare the functions in options.c, which seems overkill. Cheers, Manuel.
