>> Doesn't this match several cases more than before i.e set the range
>> start to zero fairly often?  I mean if it works fine with me and
>> the code is easier to read.
Yes.

>> Please split off the search for the non-contiguous load/stores into
>> a separate function still.  With that change it's OK from my side.
Address comment and Committed. Thanks Robin.


juzhe.zh...@rivai.ai
 
From: Robin Dapp
Date: 2023-10-17 04:22
To: Juzhe-Zhong; gcc-patches
CC: rdapp.gcc; kito.cheng; kito.cheng; jeffreyalaw
Subject: Re: [PATCH V3] RISC-V: Fix unexpected big LMUL choosing in dynamic 
LMUL model for non-adjacent load/store
> +       if (live_range && flow_bb_inside_loop_p (loop, e->src))
> + {
 
Doesn't this match several cases more than before i.e set the range
start to zero fairly often?  I mean if it works fine with me and
the code is easier to read.
 
Please split off the search for the non-contiguous load/stores into
a separate function still.  With that change it's OK from my side.
 
Regards
Robin
 

Reply via email to