On 10/17/23 12:34, Marek Polacek wrote:
On Tue, Oct 17, 2023 at 09:35:21PM +1100, Nathaniel Shead wrote:
Marek pointed out in another patch of mine [1] that I was missing an
auto_diagnostic_group to correctly associate informative notes with
their errors in structured error outputs. This patch goes through
constexpr.cc to correct this in other locations which seem to have the
same issue.
Thanks for the patch. I went through all of them and they all seem correct.
So, LGTM, but can't approve.
Thanks, I pushed it with a Reviewed-By of Marek.
Jason
