On 10/18/23 13:28, waffl3x wrote:
I will try to get something done today, but I was struggling with
writing some of the tests, there's also a lot more of them now. I also
wrote a bunch of musings in comments that I would like feedback on.
My most concrete question is, how exactly should I be testing a
pedwarn, I want to test that I get the correct warning and error with
the separate flags, do I have to create two separate tests for each one?
Yes. I tend to use letter suffixes for tests that vary only in flags
(and expected results), e.g. feature1a.C, feature1b.C.
Will do.
Instead of OPT_Wpedantic, this should be controlled by
-Wc++23-extensions (OPT_Wc__23_extensions)
Yeah, I'll do this.
If you wanted, you could add a more specific warning option for this
(e.g. -Wc++23-explicit-this) which is also affected by
-Wc++23-extensions, but I would lean toward just using the existing
flag. Up to you.
I brought it up in irc and there was some pushback to my point of view
on it, so I'll just stick with OPT_Wc__23_extensions for now. I do
think a more sophisticated interface would be beneficial but I will
bring discussion around that up again in the future.
I've seen plenty of these G_ or _ macros on strings around like in
grokfndecl for these errors.
G_("static member function %qD cannot have cv-qualifier")
G_("non-member function %qD cannot have cv-qualifier")
G_("static member function %qD cannot have ref-qualifier")
G_("non-member function %qD cannot have ref-qualifier")
I have been able to figure out it relates to translation, but not
exactly what the protocol around them is.
The protocol is described in gcc/ABOUT-GCC-NLS. In general, "strings"
passed directly to a diagnostic function don't need any decoration, but
if they're assigned to a variable first, they need G_() so they're
recognized as diagnostic strings to be added to the translation table.
The _() macro is used for strings that are going to be passed to a %s,
but better to avoid doing that for strings that need translation. N_()
is (rarely) used for strings that aren't diagnostic format strings, but
get passed to another function that passes them to _().
Jason
