Hi, ok for approval? Thanks, -Han
On Wed, May 16, 2012 at 4:49 PM, <shen...@google.com> wrote: > On 2012/05/16 23:30:28, Diego Novillo wrote: > >> On 12-05-16 19:22 , mailto:jin...@google.com wrote: >> > In my opinion, gcc/ChangeLog is for upstream commits only. >> > It is fine that you want to port upstream gcc/ChangeLog as well. > > Just >> >> > remove your identities >> > +2012-05-11 Han Shen <mailto:shen...@google.com> >> >> > + >> > + Backported r187569 from branches/google/gcc-4_6. > > >> The convention for branches is that all the commits to them should get > > >> ChangeLog entries in the file ChangeLog.<branch-tag> > > >> where <branch-tag> is generally the basename of the branch URL, though > > >> it is sometimes changed slightly. In the google branches we use the >> convention 'google-<name>' for all the branches under google/* > > > >> Diego. > > > Thanks, Jing and Diego. > > Reverted gcc/ChangeLog. > > Regards, > -Han > > http://codereview.appspot.com/6210060/ -- Han Shen | Software Engineer | shen...@google.com | +1-650-440-3330