On 10/23/23 19:51, Patrick Palka wrote:
The second patch in this series is new and ensures that the candidates
list isn't mysteriously missing some candidates when noting other
candidates due to deletedness.

-- >8 --

This patch:

   * changes splice_viable to move the non-viable candidates to the end
     of the list instead of removing them outright

Please consistently spell this "non-viable" rather than "unviable".

+tourney (struct z_candidate *&candidates, tsubst_flags_t complain)
  {
    struct z_candidate *champ = candidates, *challenger;
    int fate;
    struct z_candidate *champ_compared_to_predecessor = nullptr;
+  struct z_candidate *champ_predecessor = nullptr;
+  struct z_candidate *challenger_predecessor = champ;

Rather than adding two more variables to keep synchronized, maybe we want champ and challenger to be **, like the tail variables in splice_viable?

Jason

Reply via email to