Hi,
on 2023/11/7 11:24, HAO CHEN GUI wrote:
> Hi Kewen,
>
> Thanks for your review comments. Just one question on following
> comment.
>
> 在 2023/11/7 10:40, Kewen.Lin 写道:
>> Nit: has_arch_pwr8 would make it un-tested on Power7 default env, I'd prefer
>> to remove this "has_arch_pwr8" and append "-mdejagnu-cpu=power8" to
>> dg-options.
>
> My original propose is to test the case on p8/p9/p10. Each of them
> generate different instruction sequence. If it's assigned
But the actual test point is the same for p8/p9/p10:
+/* { dg-final { scan-assembler-times {\mvcmpequb\.} 2 } } */
+/* { dg-final { scan-assembler-not {\mcmpd\M} } } */
,it checks if we generates vector comparison, the p8/p9/p10
difference doesn't matter in this checking at least.
IMHO the consistency for vector comparison on different cpus
shouldn't be tested in this case either, it should be covered
by some other existing test cases dedicated for vector
comparison instead. But if you are eager to cover p8/p9/p10,
we can separate the test cases with separated -mdejagnu-cpu=,
but I don't feel it's worthy. :)
BR,
Kewen
> "-mdejagnu-cpu=power8", only p8 instruction sequence is generated.
> Does it lost the coverage?
>
> Thanks
> Gui Haochen
