Yes. No regression. Committed.
juzhe.zh...@rivai.ai From: Jeff Law Date: 2023-11-10 07:56 To: Juzhe-Zhong; gcc-patches CC: kito.cheng; kito.cheng; rdapp.gcc Subject: Re: [PATCH] RISC-V: Move cond_copysign from combine pattern to autovec pattern On 11/9/23 16:33, Juzhe-Zhong wrote: > Since cond_copysign has been support into match.pd (middle-end). > We don't need to support conditional copysign by RTL combine pass. > > Instead, we can support it by direct explicit cond_copysign optab. > > conditional copysign tests are already available in the testsuite. > No need to add tests. > > gcc/ChangeLog: > > * config/riscv/autovec-opt.md (*cond_copysign<mode>): Remove. > * config/riscv/autovec.md (cond_copysign<mode>): New pattern. I assume you ran the testsuite after this change to ensure there weren't any regressions? We need to make sure that we indicate what testing we've done. You don't need to run every multilib or anything like that. For a given change I trust you to run a reasonable set of test. OK assuming you've done a testsuite run. Jeff
