* Prathamesh Kulkarni: > On Mon, 20 Nov 2023 at 15:28, Florian Weimer <fwei...@redhat.com> wrote: >> >> The change to build_conditional_expr drops the downgrade >> from a pedwarn to warning for builtins for C99 and later >> language dialects. It remains a warning in C89 mode (not >> a permerror), as the -std=gnu89 -fno-permissive test shows. > Hi Florian, > It seems this patch caused a fallout for > gcc.dg/fixed-point/composite-type.c on arm, where the tests for > warnings fail. > For instance: > FAIL: gcc.dg/fixed-point/composite-type.c (test for warnings, line 71) > Excess errors: > /home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/snapshots/gcc.git~master/gcc/testsuite/gcc.dg/fixed-point/composite-type.c:71:3: > error: passing argument 1 of 'f2_sf' from incompatible pointer type > [-Wincompatible-pointer-types] > /home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/snapshots/gcc.git~master/gcc/testsuite/gcc.dg/fixed-point/composite-type.c:71:3: > error: passing argument 1 of 'f2_sf' from incompatible pointer type > [-Wincompatible-pointer-types] > (snipped rest) > > Should these warnings be now upgraded to dg-error ?
Right, a patch for this was posted (but I don't see it in the archives): From: Yang Yujie <yangyu...@loongson.cn> Subject: [PATCH] testsuite: Adjust for the new permerror -Wincompatible-pointer-types To: gcc-patches@gcc.gnu.org Cc: r...@cebitec.uni-bielefeld.de, mikest...@comcast.net, fwei...@redhat.com, Yang Yujie <yangyu...@loongson.cn> Date: Wed, 6 Dec 2023 10:29:31 +0800 (9 hours, 42 minutes, 7 seconds ago) Message-ID: <20231206022931.33437-1-yangyu...@loongson.cn> Thanks, Florian
