On Wed, Dec 06, 2023 at 10:45:22AM -0700, Jeff Law wrote: > > > On 12/6/23 05:12, Florian Weimer wrote: > > * Yang Yujie: > > > > > From: Yang Yujie <yangyu...@loongson.cn> > > > Subject: [PATCH] testsuite: Adjust for the new permerror > > > -Wincompatible-pointer-types > > > To: gcc-patches@gcc.gnu.org > > > Cc: r...@cebitec.uni-bielefeld.de, mikest...@comcast.net, > > > fwei...@redhat.com, > > > Yang Yujie <yangyu...@loongson.cn> > > > Date: Wed, 6 Dec 2023 10:29:31 +0800 (9 hours, 42 minutes, 7 seconds ago) > > > Message-ID: <20231206022931.33437-1-yangyu...@loongson.cn> > > > > > > r14-6037 turned -Wincompatible-pointer-types into a permerror, > > > which causes the following tests to fail. > > > > > > gcc/testsuite/ChangeLog: > > > > > > * gcc.dg/fixed-point/composite-type.c: replace dg-warning with dg-error. > > > --- > > > .../gcc.dg/fixed-point/composite-type.c | 64 +++++++++---------- > > > 1 file changed, 32 insertions(+), 32 deletions(-) > > > > Looks reasonable to me, but I can't approve it. > We might want to fix that from a policy standpoint :-) > > Regardless, this is OK for the trunk. Thanks Yang for taking care of it. I > don't see you in the maintainers file, so I'll go ahead and push it > momentarily. > > jeff
Thanks for the review! With this patch, I also noticed a few errors in building unpatched older software like expect-5.45.4, perl-5.28.3 and bash-5.0. Will this also be the case when GCC 14 gets released? Thanks, Yujie
