On Thu, Dec 07, 2023 at 04:13:51PM +0800, Xi Ruoyao wrote:
>
> I understand and I don't think adding {} is wrong. The problem is the
> indent change causes a large chunk of diff and it makes reviewing more
> difficult. Thus generally we should not mix real code change and format
> change in a commit.
>
> i. e. it would be better to separate it into two patches, the first adds
> {} and changes the indent, and the second changes the logic. But now I
> don't think it's needed to make a V4, just pushing this should be fine.
>
Thanks for the suggestion. It is clearer that way.
Yujie
