On 12/12/23 12:50, Jason Merrill wrote:
On 12/12/23 10:24, Jason Merrill wrote:
On 12/12/23 06:15, Jakub Jelinek wrote:
On Tue, Dec 12, 2023 at 02:13:43PM +0300, Alexander Monakov wrote:


On Tue, 12 Dec 2023, Jakub Jelinek wrote:

On Mon, Dec 11, 2023 at 05:00:50PM -0500, Jason Merrill wrote:
In discussion of PR71093 it came up that more clobber_kind options would be
useful within the C++ front-end.

gcc/ChangeLog:

    * tree-core.h (enum clobber_kind): Rename CLOBBER_EOL to
    CLOBBER_STORAGE_END.  Add CLOBBER_STORAGE_BEGIN,
    CLOBBER_OBJECT_BEGIN, CLOBBER_OBJECT_END.
    * gimple-lower-bitint.cc
    * gimple-ssa-warn-access.cc
    * gimplify.cc
    * tree-inline.cc
    * tree-ssa-ccp.cc: Adjust for rename.

Doesn't build_clobber_this in the C++ front-end need to be adjusted too?
I think it is used to place clobbers at start of the ctor (should be
CLOBBER_OBJECT_BEGIN in the new nomenclature) and end of the dtor (i.e.
CLOBBER_OBJECT_END).

You're right.

I had been thinking to leave that to Nathaniel's patch, but sure, I'll hoist those bits out:

I've now pushed this version of the patch; Nathaniel, do you want to rebase on it?

Actually, I'll take care of that.

Jason

Reply via email to