On Wed, Dec 13, 2023 at 11:03:50AM +0000, Andre Vieira (lists) wrote:
> Hmm.... I think I understand what you are saying, but I'm not sure I agree.
> So before I enabled simdclone testing for aarch64, this test had no target
> selectors. So it checked the same for 'all simdclone test targets'. Which
> seem to be x86 and amdgcn:
>
> @@ -4321,7 +4321,8 @@ proc check_effective_target_vect_simd_clones { } {
> return [check_cached_effective_target_indexed vect_simd_clones {
> expr { (([istarget i?86-*-*] || [istarget x86_64-*-*])
> && [check_effective_target_avx512f])
> || [istarget amdgcn-*-*]
> || [istarget aarch64*-*-*] }}]
> }
>
> I haven't checked what amdgcn does with this test, but I'd have to assume
> they were passing before? Though I'm not sure how amdgcn would pass the
> original:
> - /* At gimplification time, we can't decide yet which function to call.
> */
> - /* { dg-final { scan-tree-dump-times "f04 \\\(x" 2 "gimple" } } */
It can't really pass there. amdgcn certainly doesn't create 4 different
simd clones where one has avx512f isa and others don't.
gcn creates just one simd clone with simdlen 64 and that clone will never
support avx512f isa and we know that already at gimplification time.
Jakub
