On Tue, 2 Jan 2024, David Malcolm wrote: > > > + #print(f'{url_suffix=} {index_text=}') > > > > Various commented-out or "if 0" debugging code like this should probably > > be removed (or made into an actual runtime conditional if desired). > > I've removed them all.
There are still a few left. The patch is OK with the remaining commented-out code removed or made into runtime conditionals. > + #print(f'{url_suffix=} {index_text=}') Here. > +class OptFile: > + def __init__(self, opt_path, rel_path): > + """ > + Parse a .opt file. Similar to opt-gather.awk. > + """ > + self.rel_path = rel_path > + assert rel_path.startswith('gcc') > + # self.filename = os.path.basename(path) > + self.records = [] > + with open(opt_path) as f: > + flag = 0 > + for line in f: > + #print(repr(line)) And these two here (well, the commented-out setting of self.filename may be something else rather than debugging code, but much the same still applies). -- Joseph S. Myers j...@polyomino.org.uk