I have reverted those 2 commits: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=960c2620db254a1edc2cd61e608df73073b3de0d https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=b3ec98d458f2b285bb7b3fa4fcd93fd830fee069
juzhe.zh...@rivai.ai From: Palmer Dabbelt Date: 2024-01-05 11:24 To: juzhe.zhong CC: gcc-patches; Kito Cheng; Kito.cheng Subject: Re: [committed] RISC-V: Add crypto vector builtin function. On Thu, 04 Jan 2024 19:17:21 PST (-0800), juzhe.zh...@rivai.ai wrote: > Hi, Wang Feng. > > Your patch has some ICEs: > FAIL: gcc.target/riscv/rvv/base/zvbc-intrinsic.c (internal compiler error: > RTL check: expected code 'const_int', have 'reg' in vlmax_avl_type_p, at > config/riscv/riscv-v.cc:4930) > FAIL: gcc.target/riscv/rvv/base/zvbc-intrinsic.c (test for excess errors) > FAIL: gcc.target/riscv/rvv/base/zvbc_vx_constraint-1.c (internal compiler > error: RTL check: expected code 'const_int', have 'reg' in vlmax_avl_type_p, > at config/riscv/riscv-v.cc:4930) > FAIL: gcc.target/riscv/rvv/base/zvbc_vx_constraint-1.c (test for excess > errors) > FAIL: gcc.target/riscv/rvv/base/zvbc_vx_constraint-2.c (internal compiler > error: RTL check: expected code 'const_int', have 'reg' in vlmax_avl_type_p, > at config/riscv/riscv-v.cc:4930) > FAIL: gcc.target/riscv/rvv/base/zvbc_vx_constraint-2.c (test for excess > errors) So let's just revert it, it doesn't even look like it was reviewed. We've set a really bad precedent here where we're just merging a bunch of unreviewed code and sorting out the regressions in trunk, that's not the right way to do things. > > I suspect you didn't enable rtl check in the regression: > > ../../configure --enable-gcc-checking=rtl. > Plz enable rtl check in the regression tests. > > > > juzhe.zh...@rivai.ai
