On 1/7/24 10:17, Georg-Johann Lay wrote:
Am 07.01.24 um 17:45 schrieb Jeff Law:
On 1/7/24 08:53, Georg-Johann Lay wrote:
Made some tests more generic so they can pass on more targets.
Johann
--
testsuite/52641: Fix fallout from sloppy tests.
gcc/testsuite/
PR testsuite/52641
* gcc.dg/torture/pr110838.c: Use proper shift offset to get MSB
or int.
* gcc.dg/torture/pr112282.c: Use at least 32 bits for :20
bit-fields.
* gcc.dg/tree-ssa/bitcmp-5.c: Use integral type with 32 bits or
more.
* gcc.dg/tree-ssa/bitcmp-6.c: Same.
* gcc.dg/tree-ssa/cltz-complement-max.c: Same.
* gcc.dg/tree-ssa/cltz-max.c: Same.
* gcc.dg/tree-ssa/if-to-switch-8.c: Use literals that fit int.
* gcc.dg/tree-ssa/if-to-switch-9.c [avr]: Set
case-values-threshold=3.
* gcc.dg/tree-ssa/negneg-3.c: Discriminate [not] large_double.
* gcc.dg/tree-ssa/phi-opt-25b.c: Use types of correct widths for
__builtin_bswapN.
* gcc.dg/tree-ssa/pr55177-1.c: Same.
* gcc.dg/tree-ssa/popcount-max.c: Use int32_t where required.
* gcc.dg/tree-ssa/pr111583-1.c: Use intptr_t as needed.
* gcc.dg/tree-ssa/pr111583-2.c: Same.
Are you checking this on other targets? My tester just started
complaining about these (ft30-elf, fr30-elf), more expected as today's
run progresses)
Tests that now fail, but worked before (2 tests):
ft32-sim: gcc: gcc.dg/tree-ssa/phi-opt-25b.c (test for excess errors)
ft32-sim: gcc: gcc.dg/tree-ssa/phi-opt-25b.c (test for excess errors)
Jeff
Hi Jeff, thanks for fixing the typo.
It slipped through because "int short" works in that place.
Usually when going after PR52641 I used dg-require, dg-skip or
dg-xfail for tests that fail on 16-bit int etc.
Yea. We're not terribly good about keeping the testsuite 16bit clean.
Just not that much interest in such ports. Just to be clear -- I'm
happy to see the testsuite improved by reducing noise, even on these
lesser used platforms.
The take above was more ambitious in that it tried to make some
tests work without breaking other platforms of course.
ACK. It happens. Just a reminder to be careful. I've already fixed it
on the trunk.
It's not always easy to get the intent of a test case and how
to make it more generic though.
Absolutely true.
Thanks again,
jeff
