On 1/7/24 16:07, 钟居哲 wrote:
Since in the previous review from Robin, he have ever asked me change std::max into MAX,
I thought the policy is preferring MAX instead of std::max.

I change the codes to make them consistent but it seems I am wrong.

So is it reasonable that I change all RVV-related codes back to use std::max/min ?

If yes, I can send a patch to adapt all of them in RVV related codes.
If Robin asked for MAX, let's leave it as-is. It's not a hard requirement, just a general direction towards std:: when we can. It may be the case that with other codes using MAX nearby that keeping consistency is better.

jeff

Reply via email to